[FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

Michael Niedermayer michael at niedermayer.cc
Mon Dec 19 23:13:02 EET 2016


On Sun, Dec 18, 2016 at 10:49:36AM +0100, Nicolas George wrote:
> ffmpeg | branch: master | Nicolas George <george at nsup.org> | Sun Jan  3 15:44:42 2016 +0100| [02aa0701ae0dc2def8db640c9e3c06dc1b5de70c] | committer: Nicolas George
> 
> lavfi: make filter_frame non-recursive.
> 
> A lot of changes happen at the same time:
> 
> - Add a framequeue fifo to AVFilterLink.
> 
> - split AVFilterLink.status into status_in and status_out: requires
>   changes to the few filters and programs that use it directly
>   (f_interleave, split, filtfmts).
> 
> - Add a field ready to AVFilterContext, marking when the filter is ready
>   and its activation priority.
> 
> - Add flags to mark blocked links.
> 
> - Change ff_filter_frame() to enqueue the frame.
> 
> - Change all filtering functions to update the ready field and the
>   blocked flags.
> 
> - Update ff_filter_graph_run_once() to use the ready field.
> 
> - buffersrc: always push the frame immediately.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=02aa0701ae0dc2def8db640c9e3c06dc1b5de70c
> ---

this breaks

./ffmpeg -i ~/tickets/4329/bogus_video.mp4 -vframes 50 -vf crop=720:404   test.mov

(no audio in the output)

one has to increase vframes to 70
to get some audi oto appear at the begin, this seems odd
file should be this:
http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4329/bogus_video.mp4

0,       -800,          0,      400,      794, 0x3ad604c7
0,       -400,        800,      400,       22, 0x3a09051b, F=0x0
1,      -1024,      -1024,     1024,        6, 0x037a013d, F=0x5, S=1,       10, 0x00240004
0,          0,        400,      400,       20, 0x21b203c2, F=0x0
1,          0,          0,     1024,        6, 0x037a013d
1,       1024,       1024,     1024,        6, 0x037a013d
0,        400,       1200,      400,    12769, 0x9a399624, F=0x0
1,       2048,       2048,     1024,        6, 0x037a013d
1,       3072,       3072,     1024,        6, 0x037a013d
0,        800,       2000,      400,     5653, 0x395c3070, F=0x0
1,       4096,       4096,     1024,        6, 0x037a013d
0,       1200,       1600,      400,     2146, 0x94f1304b, F=0x0
1,       5120,       5120,     1024,      470, 0xe6a7ed9f
1,       6144,       6144,     1024,      332, 0x64fca77e
0,       1600,       2800,      400,     5723, 0xe9ee0c94, F=0x0
1,       7168,       7168,     1024,      405, 0x4b7dc5db
0,       2000,       2400,      400,     1851, 0xe10c8e42, F=0x0
1,       8192,       8192,     1024,     1207, 0x4076622a
1,       9216,       9216,     1008,      634, 0x25e31eab
0,       2400,       3600,      400,     6172, 0x438f1c86, F=0x0
0,       2800,       3200,      400,     1993, 0x4dd4f5dd, F=0x0
0,       3200,       4400,      400,     5876, 0x47264a92, F=0x0
0,       3600,       4000,      400,     2060, 0x678ffcd6, F=0x0
0,       4000,       5200,      400,     6296, 0xc4fc26bd, F=0x0
0,       4400,       4800,      400,     2376, 0x56209df9, F=0x0
0,       4800,       6000,      400,     7232, 0x4ee9fc93, F=0x0
0,       5200,       5600,      400,     2461, 0xf39bd2ac, F=0x0
0,       5600,       6800,      400,     6890, 0xc26e86cd, F=0x0
0,       6000,       6400,      400,     1861, 0x3b6d90d4, F=0x0
0,       6400,       7600,      400,     5593, 0x39bfc6d7, F=0x0
0,       6800,       7200,      400,     1489, 0x9342de08, F=0x0
0,       7200,       8400,      400,     5673, 0x508b00d7, F=0x0
0,       7600,       8000,      400,     1336, 0xc5287c4d, F=0x0
0,       8000,       9200,      400,     4875, 0x14755c98, F=0x0
0,       8400,       8800,      400,     1160, 0xaf9b46dd, F=0x0
0,       8800,      10000,      400,     4665, 0x9f5bffb6, F=0x0
0,       9200,       9600,      400,     1167, 0xf4964f57, F=0x0
0,       9600,      10800,      400,     3243, 0x4734579f, F=0x0
0,      10000,      10400,      400,     1136, 0xb4b33f0a, F=0x0
0,      10400,      11200,      400,     8957, 0x61f15da3
0,      10800,      11600,      400,     5228, 0x33b41a30, F=0x0
0,      11200,      12000,      400,     5252, 0x53095cf9, F=0x0
0,      11600,      12400,      400,     5148, 0x8f881708, F=0x0
0,      12000,      12800,      400,     5722, 0x64230ea4, F=0x0
0,      12400,      13200,      400,     3836, 0x1c9d7023, F=0x0
0,      12800,      13600,      400,     4098, 0xcd85effa, F=0x0
0,      13200,      14000,      400,     6465, 0x2e9fae5e, F=0x0
0,      13600,      14400,      400,     6251, 0xaa0d4c0e, F=0x0
0,      14000,      14800,      400,     5825, 0xd6a282f2, F=0x0
0,      14400,      15200,      400,     5614, 0xef5d05a4, F=0x0
0,      14800,      15600,      400,     5438, 0x599a99f2, F=0x0
0,      15200,      16000,      400,     5026, 0x83fba1b0, F=0x0
0,      15600,      16400,      400,     5069, 0x51d8da52, F=0x0
0,      16000,      16800,      400,     5762, 0xff3d5071, F=0x0
0,      16400,      17200,      400,     5541, 0xf31ac340, F=0x0
0,      16800,      17600,      400,     5457, 0xdb7a926f, F=0x0
0,      17200,      18000,      400,    23449, 0x903797bc, F=0x0
0,      17600,      19200,      400,     6361, 0x24b56255, F=0x0
0,      18000,      18800,      400,     2005, 0xf82acf1f, F=0x0
0,      18400,      18400,      400,     1240, 0x68a16ee9, F=0x0
0,      18800,      20000,      400,     6393, 0x74c776b8, F=0x0
0,      19200,      19600,      400,     1816, 0xe57fa0db, F=0x0
0,      19600,      20800,      400,     6587, 0xb4669c0b, F=0x0
0,      20000,      20400,      400,     1858, 0x57dc9523, F=0x0
0,      20400,      21600,      400,     6786, 0xf4553b4c, F=0x0
0,      20800,      21200,      400,     1716, 0x496e4c21, F=0x0
0,      21200,      22800,      400,     7390, 0xf6d9544f, F=0x0
0,      21600,      22400,      400,     1168, 0xf28451b5, F=0x0
0,      22000,      22000,      400,     1693, 0xf77755ab, F=0x0
0,      22400,      23600,      400,     6425, 0x27cd6681, F=0x0
0,      22800,      23200,      400,     1084, 0x4b551dbd, F=0x0
0,      23200,      24800,      400,     7144, 0xe4e1009f, F=0x0
0,      23600,      24400,      400,     1838, 0x499e97cd, F=0x0
0,      24000,      24000,      400,     1050, 0x2d5619f5, F=0x0
0,      24400,      26000,      400,     6081, 0x4b6ff41b, F=0x0
0,      24800,      25600,      400,     1161, 0x2d4c5dab, F=0x0
0,      25200,      25200,      400,     1730, 0x22d762ae, F=0x0
0,      25600,      27200,      400,     4340, 0x30fb7989, F=0x0
0,      26000,      26800,      400,     1599, 0x22c92c12, F=0x0
0,      26400,      26400,      400,     1043, 0x772100f4, F=0x0
0,      26800,      27600,      400,     1867, 0xe28f9673, F=0x0
frame=   70 fps=0.0 q=-1.0 Lsize=       5kB time=00:00:02.23 bitrate=  19.7kbits/s speed=2.71e+03x


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161219/a56accef/attachment.sig>


More information about the ffmpeg-devel mailing list