[FFmpeg-devel] [FFmpeg-cvslog] lavfi: make filter_frame non-recursive.

[Michael Niedermayer]

On Sun, Dec 18, 2016 at 10:49:36AM +0100, Nicolas George wrote:
> ffmpeg | branch: master | Nicolas George <george at nsup.org> | Sun Jan  3 15:44:42 2016 +0100| [02aa0701ae0dc2def8db640c9e3c06dc1b5de70c] | committer: Nicolas George
> 
> lavfi: make filter_frame non-recursive.
> 
> A lot of changes happen at the same time:
> 
> - Add a framequeue fifo to AVFilterLink.
> 
> - split AVFilterLink.status into status_in and status_out: requires
>   changes to the few filters and programs that use it directly
>   (f_interleave, split, filtfmts).
> 
> - Add a field ready to AVFilterContext, marking when the filter is ready
>   and its activation priority.
> 
> - Add flags to mark blocked links.
> 
> - Change ff_filter_frame() to enqueue the frame.
> 
> - Change all filtering functions to update the ready field and the
>   blocked flags.
> 
> - Update ff_filter_graph_run_once() to use the ready field.
> 
> - buffersrc: always push the frame immediately.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=02aa0701ae0dc2def8db640c9e3c06dc1b5de70c
> ---

i dont know if this is a bug or just somethig that by sheer bad luck
becomes vissible after this but
./ffmpeg -i cvid/dday.mov -vframes 30  -vcodec huffyuv -y -acodec pcm_s16le out3b.avi ; md5sum out3b.avi
gives different outputs from time to time
needs threads on the encoder side, huffyuv, vframes (audio codec irrelevant)

difference in output files looks like this:
valgrind shows nothing (but difference occurs under valgrind)
should be here:
http://samples.ffmpeg.org/V-codecs/CVID/grayscale/dday.mov

--- A   2016-12-19 23:36:43.297001535 +0100
+++ B   2016-12-19 23:36:47.605001627 +0100
@@ -50,9 +50,7 @@
 0,         16,         16,        1,    54316, 0xdca6a02a
 1,      18728,      18728,     1024,     2048, 0xf24df16c
 0,         17,         17,        1,    55204, 0xa93a73e6
-1,      19752,      19752,     1024,     2048, 0x27c11d5c
 0,         18,         18,        1,    54872, 0x8b01d9b0
-1,      20776,      20776,     1024,     2048, 0x77e00ab9
 0,         19,         19,        1,    54544, 0x752b168f
 0,         20,         20,        1,    58916, 0x1596d7cf
 0,         21,         21,        1,    53868, 0x0f286854



[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161219/a057d3ba/attachment.sig>