[FFmpeg-devel] [PATCH] configure: Check build with some header not just preprocessing for testing --std=c11

[James Almer]

On 12/28/2016 7:41 PM, Michael Niedermayer wrote:
> Fixes build failure on FreeBSD with gcc 4.7
> 
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  configure | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index d723b8e2a6..706346abc9 100755
> --- a/configure
> +++ b/configure
> @@ -1201,13 +1201,14 @@ check_cpp_condition(){
>  EOF
>  }
>  
> -test_cflags_cpp(){
> -    log test_cflags_cpp "$@"
> +test_cflags_cc(){
> +    log test_cflags_cc "$@"
>      flags=$1
>      condition=$2
>      shift 2
>      set -- $($cflags_filter "$flags")
> -    check_cpp "$@" <<EOF
> +    check_cc "$@" <<EOF
> +#include <ctype.h>

Maybe make the header an argument instead of hardcoding it, same as
check_cpp_condition().

LGTM in any case.

>  #if !($condition)
>  #error "unsatisfied condition: $condition"
>  #endif
> @@ -4625,7 +4626,7 @@ add_cxxflags -std=c++98
>  
>  # some compilers silently accept -std=c11, so we also need to check that the
>  # version macro is defined properly
> -if test_cflags_cpp -std=c11 "__STDC_VERSION__ >= 201112L"; then
> +if test_cflags_cc -std=c11 "__STDC_VERSION__ >= 201112L"; then
>      add_cflags -std=c11
>  else
>      check_cflags -std=c99
>