[FFmpeg-devel] [PATCH] configure: Check build with some header not just preprocessing for testing --std=c11

[Michael Niedermayer]

On Fri, Dec 30, 2016 at 02:31:14PM -0300, James Almer wrote:
> On 12/28/2016 7:41 PM, Michael Niedermayer wrote:
> > Fixes build failure on FreeBSD with gcc 4.7
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  configure | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/configure b/configure
> > index d723b8e2a6..706346abc9 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1201,13 +1201,14 @@ check_cpp_condition(){
> >  EOF
> >  }
> >  
> > -test_cflags_cpp(){
> > -    log test_cflags_cpp "$@"
> > +test_cflags_cc(){
> > +    log test_cflags_cc "$@"
> >      flags=$1
> >      condition=$2
> >      shift 2
> >      set -- $($cflags_filter "$flags")
> > -    check_cpp "$@" <<EOF
> > +    check_cc "$@" <<EOF
> > +#include <ctype.h>
> 
> Maybe make the header an argument instead of hardcoding it, same as
> check_cpp_condition().

changed


> 
> LGTM in any case.

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161231/33b19223/attachment.sig>