[FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

[Michael Niedermayer]

On Sun, Jan 24, 2016 at 12:52:37PM +0100, Andreas Cadhalpun wrote:
> On 24.01.2016 03:19, Hendrik Leppkes wrote:
> > The hastly pushed fix doesn't actually work,
> 
> It might not work in your environment, but it worked in Charlie's tests.
> 
> > all my MSVC fate boxes are still broken, ie.
> > http://fatebeta.ffmpeg.org/report/x86_32-msvc14-dll-windows-native/20160123234847
> 
> They now use paths with 'C:\' twice:
> C:\Dev\ffmpeg\git\C:\Dev\BuildEnv\MSYS2\Dev\ffmpeg\fate\x86_32-msvc2015-shared\build\libavdevice\avdevice.o
> 
> I think SRC_PATH, which is also set using $(pwd), needs the same adjustment as DST_PATH.
> 
> > Lets just revert this entire batch and re-try after proper testing and review.
> 
> You're very quick to suggest a revert here, but very reluctant about reverting
> commit 31741ae. That's not consistent.
> Thus I object to reverting this before the regression caused by 31741ae is fixed.
> 
> Also, please be a bit more constructive. Just complaining that it doesn't work
> in your setup is not helpful, as I don't have that setup and thus can't investigate
> the problem. At the very least I'd need to see the output of 'make V=1'.

btw, i might be wrong but maybe this can be resolved quicker if you
and nevcairiel discuss this on IRC or something

just guessing ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160124/811b0643/attachment.sig>