[FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

[Hendrik Leppkes]

On Sun, Jan 24, 2016 at 12:52 PM, Andreas Cadhalpun
<andreas.cadhalpun at googlemail.com> wrote:
> On 24.01.2016 03:19, Hendrik Leppkes wrote:
>> The hastly pushed fix doesn't actually work,
>
> It might not work in your environment, but it worked in Charlie's tests.
>
>> all my MSVC fate boxes are still broken, ie.
>> http://fatebeta.ffmpeg.org/report/x86_32-msvc14-dll-windows-native/20160123234847
>
> They now use paths with 'C:\' twice:
> C:\Dev\ffmpeg\git\C:\Dev\BuildEnv\MSYS2\Dev\ffmpeg\fate\x86_32-msvc2015-shared\build\libavdevice\avdevice.o
>
> I think SRC_PATH, which is also set using $(pwd), needs the same adjustment as DST_PATH.
>
>> Lets just revert this entire batch and re-try after proper testing and review.
>
> You're very quick to suggest a revert here, but very reluctant about reverting
> commit 31741ae. That's not consistent.

Broken build of git master and some behavior change you disagree with
are rather different things.

> Thus I object to reverting this before the regression caused by 31741ae is fixed.

So you break building of git master, and you try to leverage this to
get your own agenda forward? Seriously?
I already conceded the other issue as long as it doesn't cause serious
regressions (ie. vp9), so get over yourself. Is this how debian does
business? Sounds like a fun place to be.

>
> Also, please be a bit more constructive. Just complaining that it doesn't work
> in your setup is not helpful, as I don't have that setup and thus can't investigate
> the problem. At the very least I'd need to see the output of 'make V=1'.
>

Here have some output:
D:\Multimedia\ffmpeg\build>make V=1
cl -nologo -ID:/Multimedia/ffmpeg/build/
-I/d/Multimedia/ffmpeg/develop/ -D_ISOC99_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_WIN32_WINNT=0x0502
-DZLIB_CONST -DHAVE_AV_CONFIG_H -ID:/Multimedia/ffmpeg/build/
-I/d/Multimedia/ffmpeg/develop/ -D_ISOC99_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_WIN32_WINNT=0x0502
-DZLIB_CONST -DHAVE_AV_CONFIG_H -nologo -D_USE_MATH_DEFINES
-D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS    -Z7 -W4
-wd4244 -wd4127 -wd4018 -wd4389 -wd4146 -wd4057 -wd4204 -wd4706
-wd4305 -wd4152 -wd4324 -we4013 -wd4100 -wd4214 -wd4307 -wd4273
-wd4554 -wd4701 -O2   -Oy-  -showIncludes -Zs
/d/Multimedia/ffmpeg/develop/libavdevice/alldevices.c 2>&1 | awk
'/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($0,
/ /)) print "libavdevice/alldevices.o:", $0 }' >
libavdevice/alldevices.d
cd /d/Multimedia/ffmpeg/develop; if [ -n
"/d/Multimedia/ffmpeg/develop" ]; then dest=libavdevice/alldevices.c;
else dest=D:/Multimedia/ffmpeg/build//d/Multimedia/ffmpeg/develop/libavdevice/alldevices.c;
fi; cl -ID:/Multimedia/ffmpeg/build/ -I/d/Multimedia/ffmpeg/develop/
-D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_WIN32_WINNT=0x0502 -DZLIB_CONST -DHAVE_AV_CONFIG_H -nologo
-D_USE_MATH_DEFINES -D_CRT_SECURE_NO_WARNINGS
-D_CRT_NONSTDC_NO_WARNINGS    -Z7 -W4 -wd4244 -wd4127 -wd4018 -wd4389
-wd4146 -wd4057 -wd4204 -wd4706 -wd4305 -wd4152 -wd4324 -we4013
-wd4100 -wd4214 -wd4307 -wd4273 -wd4554 -wd4701 -O2   -Oy-   -c
-FoD:/Multimedia/ffmpeg/build/libavdevice/alldevices.o $dest
alldevices.c
D:\Multimedia\ffmpeg\develop\libavdevice\alldevices.c : fatal error
C1083: Cannot open compiler generated file:
'D:\Multimedia\ffmpeg\develop\D:\Multimedia\BuildEnv\MSYS2\Multimedia\ffmpeg\build\libavdevice\alldevices.o':
Invalid argument
/d/Multimedia/ffmpeg/develop/common.mak:61: recipe for target
'libavdevice/alldevices.o' failed
make: *** [libavdevice/alldevices.o] Error 1

It seems to screw up somewhere in the middle wherever this "dest=..."
comes from, I don't really know the makefiles that well.

- Hendrik