[FFmpeg-devel] [PATCH 1/2] lavu/dict: Add new flag to allow multiple equal keys.

[Hendrik Leppkes]

On Mon, Mar 28, 2016 at 12:05 PM, Marton Balint <cus at passwd.hu> wrote:
>
> On Mon, 28 Mar 2016, Hendrik Leppkes wrote:
>
>> People that don't speak up at all may approve silently (or at least
>> not disapprove), someone that raised issues should give an explicit
>> OK/Nevermind/whatever, agreeing with you or withdrawing his
>> complaints, there is no "silent" option there.
>
>
> This seems unreasonable, beacuse this way a silent person can block a patch
> forever, which is not optimal.
>
> What I usually do is after a week of silence if I feel that I addressed the
> concerns, or there is no known way to improve the patch, I send one last
> ping explicitly stating that I will apply the patch soon. (whithin 1-2
> days). And if the silence remains, I apply it.
>

If you send a mail explicitly stating that and the intention to move
forward if no further feedback arrives, then its usually fine. Didn't
happen here though.

 - Hendrik