[FFmpeg-devel] [PATCH 1/2] lavu/dict: Add new flag to allow multiple equal keys.
Thilo Borgmann
thilo.borgmann at mail.de
Tue Mar 29 06:38:51 CEST 2016
Am 28.03.16 um 12:14 schrieb Hendrik Leppkes:
> On Mon, Mar 28, 2016 at 12:05 PM, Marton Balint <cus at passwd.hu> wrote:
>>
>> On Mon, 28 Mar 2016, Hendrik Leppkes wrote:
>>
>>> People that don't speak up at all may approve silently (or at least
>>> not disapprove), someone that raised issues should give an explicit
>>> OK/Nevermind/whatever, agreeing with you or withdrawing his
>>> complaints, there is no "silent" option there.
>>
>>
>> This seems unreasonable, beacuse this way a silent person can block a patch
>> forever, which is not optimal.
>>
>> What I usually do is after a week of silence if I feel that I addressed the
>> concerns, or there is no known way to improve the patch, I send one last
>> ping explicitly stating that I will apply the patch soon. (whithin 1-2
>> days). And if the silence remains, I apply it.
>>
>
> If you send a mail explicitly stating that and the intention to move
> forward if no further feedback arrives, then its usually fine. Didn't
> happen here though.
"ping": http://article.gmane.org/gmane.comp.video.ffmpeg.devel/211969
"don't like": http://article.gmane.org/gmane.comp.video.ffmpeg.devel/211970
"what to do?": http://article.gmane.org/gmane.comp.video.ffmpeg.devel/211971
-silence-
Ok, or not, whatever.
My actions were not ideal either and I regret it. In the future I will be more
sensible for pending people. And maybe wm4 might consider not to wait for others
to squeeze his concerns out of him.
I don't see any actions in bad faith. Let's go back to work everyone, please.
-Thilo
More information about the ffmpeg-devel
mailing list