[FFmpeg-devel] [PATCH 3/3] avformat/utils: Slightly un-clutter code in determinable_frame_size() by using a switch

[wm4]

On Sun,  4 Jun 2017 02:25:46 +0200
Michael Niedermayer <michael at niedermayer.cc> wrote:

> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/utils.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index c5f1eac185..bbc7a7b547 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -894,12 +894,13 @@ int ff_read_packet(AVFormatContext *s, AVPacket *pkt)
>  
>  static int determinable_frame_size(AVCodecContext *avctx)
>  {
> -    if (/*avctx->codec_id == AV_CODEC_ID_AAC ||*/
> -        avctx->codec_id == AV_CODEC_ID_MP1 ||
> -        avctx->codec_id == AV_CODEC_ID_MP2 ||
> -        avctx->codec_id == AV_CODEC_ID_MP3/* ||
> -        avctx->codec_id == AV_CODEC_ID_CELT*/)
> +    switch(avctx->codec_id) {
> +    case AV_CODEC_ID_MP1:
> +    case AV_CODEC_ID_MP2:
> +    case AV_CODEC_ID_MP3:
>          return 1;
> +    }
> +
>      return 0;
>  }
>  

Seems like an improvement.

Is there any reason for this function to exist, though? (I bet nobody
knows.)