[FFmpeg-devel] [PATCH 3/3] avformat/utils: Slightly un-clutter code in determinable_frame_size() by using a switch

[Michael Niedermayer]

On Tue, Jun 06, 2017 at 03:57:22PM +0200, wm4 wrote:
> On Sun,  4 Jun 2017 02:25:46 +0200
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/utils.c | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index c5f1eac185..bbc7a7b547 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -894,12 +894,13 @@ int ff_read_packet(AVFormatContext *s, AVPacket *pkt)
> >  
> >  static int determinable_frame_size(AVCodecContext *avctx)
> >  {
> > -    if (/*avctx->codec_id == AV_CODEC_ID_AAC ||*/
> > -        avctx->codec_id == AV_CODEC_ID_MP1 ||
> > -        avctx->codec_id == AV_CODEC_ID_MP2 ||
> > -        avctx->codec_id == AV_CODEC_ID_MP3/* ||
> > -        avctx->codec_id == AV_CODEC_ID_CELT*/)
> > +    switch(avctx->codec_id) {
> > +    case AV_CODEC_ID_MP1:
> > +    case AV_CODEC_ID_MP2:
> > +    case AV_CODEC_ID_MP3:
> >          return 1;
> > +    }
> > +
> >      return 0;
> >  }
> >  
> 
> Seems like an improvement.

applied


> 
> Is there any reason for this function to exist, though? (I bet nobody
> knows.)

If i remember correctly
It lists the audio codecs for which the parser will set the frame
size upon encountering a valid undamaged (key) frame.
I think some streams require waiting for this point to have correct
information.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170606/14806314/attachment.sig>