[FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: fix memleak of extradata

[James Almer]

On 7/11/2019 9:29 AM, Michael Niedermayer wrote:
> Fixes: memleak
> Fixes: 15535/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5692162424963072
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  tools/target_dec_fuzzer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
> index f456db0e7b..a2ef94139b 100644
> --- a/tools/target_dec_fuzzer.c
> +++ b/tools/target_dec_fuzzer.c
> @@ -201,7 +201,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
>  
>      int res = avcodec_open2(ctx, c, NULL);
>      if (res < 0) {
> -        av_free(ctx);
> +        avcodec_free_context(&ctx);

Wasn't this fixed by b1febda061?
>          av_free(parser_avctx);
>          return 0; // Failure of avcodec_open2() does not imply that a issue was found
>      }
>