[FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: fix memleak of extradata

[Michael Niedermayer]

On Thu, Jul 11, 2019 at 11:34:10AM -0300, James Almer wrote:
> On 7/11/2019 9:29 AM, Michael Niedermayer wrote:
> > Fixes: memleak
> > Fixes: 15535/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5692162424963072
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  tools/target_dec_fuzzer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
> > index f456db0e7b..a2ef94139b 100644
> > --- a/tools/target_dec_fuzzer.c
> > +++ b/tools/target_dec_fuzzer.c
> > @@ -201,7 +201,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
> >  
> >      int res = avcodec_open2(ctx, c, NULL);
> >      if (res < 0) {
> > -        av_free(ctx);
> > +        avcodec_free_context(&ctx);
> 
> Wasn't this fixed by b1febda061?

no, this still occurs without the patch here

==24989==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 183 byte(s) in 1 object(s) allocated from:

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190713/b033458f/attachment.sig>