[FFmpeg-devel] [PATCH] Increasing the max length of control URI to 2048 characters, as urls of some RTSP streams do exceed this limit.

[Yiğit (Yeet) Uyan]

Hi, the patch file I have sent via git-email does not seem to be listed in
the patchwork list of patches. Can somebody comment on the file/mimetype,
and if everything looks good?

First time submitting a patch, please let me know if there is any other
thing I need to do.

*•  **Yiğit (Yeet) Uyan*
*•*  Smart Home Intelligence | Google Home
*•*  yigituyan at google.com



On Thu, Aug 6, 2020 at 4:20 PM Yiğit (Yeet) Uyan <yigituyan at google.com>
wrote:

> Not quite. RTSP/S links follow a similar pattern as common web URIs, i.e.
> <rtsps://my.camera.server:port/...>, and in many cases these links are
> generated, routed and modified by common underlying infrastructure. AFAIK,
> the common conception for the web when parsing a URI is to expect up to
> 2000 characters.
>
>
> https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers
>
> The link above is for browsers, but it is very similar in many other web
> technologies as well. Hence if there is going to be a hard limitation at
> some number, putting it to 2048 characters would make sense (and unblock
> the problems we are experiencing with rtsps streams).
>
>
> *•  **Yiğit (Yeet) Uyan*
> *•*  Smart Home Intelligence | Google Home
> *•*  yigituyan at google.com
>
>
>
> On Thu, Aug 6, 2020 at 2:15 AM mypopy at gmail.com <mypopy at gmail.com> wrote:
>
>> On Thu, Aug 6, 2020 at 11:47 AM Yiğit (Yeet) Uyan
>> <yigituyan-at-google.com at ffmpeg.org> wrote:
>> >
>> > Hey Zhilizhao,
>> >
>> > The RTSPState you mentioned is ok, but we need to get the char
>> control_uri
>> > buffer from 1024 characters to 2048. Some of the long rtsps links are
>> > getting cut, and cannot play. Can you help getting this patch to the
>> next
>> > version? The patch does not show up in https://patchwork.ffmpeg.org/
>> at the
>> > moment.
>> >
>> > *•  **Yiğit (Yeet) Uyan*
>> > *•*  Smart Home Intelligence | Google Home
>> > *•*  yigituyan at google.com
>> >
>> >
>> >
>> > On Wed, Aug 5, 2020 at 7:58 PM zhilizhao <quinkblack at foxmail.com>
>> wrote:
>> >
>> > >
>> > >
>> > > > On Aug 6, 2020, at 10:46 AM, zhilizhao <quinkblack at foxmail.com>
>> wrote:
>> > > >
>> > > >
>> > > >
>> > > >> On Aug 6, 2020, at 6:38 AM, Yiğit (Yeet) Uyan <
>> > > yigituyan-at-google.com at ffmpeg.org> wrote:
>> > > >>
>> > > >> Hello everyone,
>> > > >>
>> > > >> This is the first time for me to send a patch via email. Is this
>> the
>> > > >> correct format?
>> > > >>
>> > > >> I would appreciate it if someone could confirm, and if there is
>> anything
>> > > >> else I need to do to get it into upcoming releases.
>> > > >>
>> > > >> Best,
>> > > >>
>> > > >> *•  **Yiğit (Yeet) Uyan*
>> > > >> *•*  Smart Home Intelligence | Google Home
>> > > >> *•*  yigituyan at google.com
>> > > >>
>> > > >>
>> > > >>
>> > > >> On Wed, Aug 5, 2020 at 11:30 AM <device.access.test at gmail.com>
>> wrote:
>> > > >>
>> > > >>> From: Yiğit (Yeet) Uyan <yigituyan at google.com>
>> > > >>>
>> > > >>> Signed-off-by: Yiğit (Yeet) Uyan <yigituyan at google.com>
>> > > >>> ---
>> > > >>> libavformat/rtsp.h | 2 +-
>> > > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> > > >>>
>> > > >>> diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h
>> > > >>> index 54a9a30c16..2b37f5b49f 100644
>> > > >>> --- a/libavformat/rtsp.h
>> > > >>> +++ b/libavformat/rtsp.h
>> > > >>> @@ -315,7 +315,7 @@ typedef struct RTSPState {
>> > > >>>    /** some MS RTSP streams contain a URL in the SDP that we need
>> to
>> > > use
>> > > >>>     * for all subsequent RTSP requests, rather than the input
>> URI; in
>> > > >>>     * other cases, this is a copy of AVFormatContext->filename. */
>> > > >>> -    char control_uri[1024];
>> > > >>> +    char control_uri[2048];
>> I know 1024 is a hard limitation, but this patch have the same problem if
>> the length of the Control URL Attribute in RTSP SDP > 2048
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>
>