[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_av1: abort when the written inferred value is not the expected one

[Michael Niedermayer]

On Thu, Jun 11, 2020 at 01:13:20PM -0300, James Almer wrote:
> If this happens, it's a sign of parsing issues earlier in the process, or
> misuse by the calling module.
> 
> Prevents creating invalid bitstreams.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/cbs_av1.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Iam ok with this but there are other people who know this code
better than i do.

Also long term, it may be interresting to split the check between
inferences that refer to security vs. ones refering to compliance
There may be situations where passing non compliant values through
is desirable

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200614/f6467e7d/attachment.sig>