[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_av1: abort when the written inferred value is not the expected one

[James Almer]

On 6/14/2020 1:24 PM, Michael Niedermayer wrote:
> On Thu, Jun 11, 2020 at 01:13:20PM -0300, James Almer wrote:
>> If this happens, it's a sign of parsing issues earlier in the process, or
>> misuse by the calling module.
>>
>> Prevents creating invalid bitstreams.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavcodec/cbs_av1.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Iam ok with this but there are other people who know this code
> better than i do.

Pushed and backported these two patches, but postponed the split
reference one. I want Mark's opinion on the approach before applying it.

Thanks.

> 
> Also long term, it may be interresting to split the check between
> inferences that refer to security vs. ones refering to compliance
> There may be situations where passing non compliant values through
> is desirable
> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>