[FFmpeg-devel] [PATCH v9 23/25] avcodec/subtitles: Migrate subtitle encoders to frame-based API

Michael Niedermayer michael at niedermayer.cc
Thu Oct 27 20:53:49 EEST 2022


On Tue, Oct 25, 2022 at 09:13:44AM +0000, softworkz wrote:
> From: softworkz <softworkz at hotmail.com>
> 
> and provide a compatibility shim for the legacy api
> 
> Signed-off-by: softworkz <softworkz at hotmail.com>
> ---
>  libavcodec/assenc.c         | 189 ++++++++++++++++++++++++++++++------
>  libavcodec/avcodec.h        |   5 +-
>  libavcodec/codec_internal.h |  12 ---
>  libavcodec/dvbsubenc.c      |  96 ++++++++++--------
>  libavcodec/dvdsubenc.c      | 103 ++++++++++++--------
>  libavcodec/encode.c         |  61 +++++++++++-
>  libavcodec/movtextenc.c     | 114 ++++++++++++++++------
>  libavcodec/srtenc.c         | 108 ++++++++++++++-------
>  libavcodec/tests/avcodec.c  |   5 +-
>  libavcodec/ttmlenc.c        | 101 ++++++++++++++-----
>  libavcodec/utils.c          |   1 -
>  libavcodec/webvttenc.c      |  86 +++++++++++-----
>  libavcodec/xsubenc.c        |  88 ++++++++++-------
>  13 files changed, 689 insertions(+), 280 deletions(-)

Causes this testcase to fail:
./ffmpeg -i 'bgc.sub.dub.ogm'  -vframes 3 -bitexact -y nosubs.webm

https://samples.ffmpeg.org/ogg/

I did not investgate why or if this a bug or expected. Just reporting a difference
ive seen

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221027/bcb0aca3/attachment.sig>


More information about the ffmpeg-devel mailing list