[FFmpeg-devel] [PATCH v9 23/25] avcodec/subtitles: Migrate subtitle encoders to frame-based API

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Thursday, October 27, 2022 7:54 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v9 23/25] avcodec/subtitles:
> Migrate subtitle encoders to frame-based API
> 
> On Tue, Oct 25, 2022 at 09:13:44AM +0000, softworkz wrote:
> > From: softworkz <softworkz at hotmail.com>
> >
> > and provide a compatibility shim for the legacy api
> >
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  libavcodec/assenc.c         | 189 ++++++++++++++++++++++++++++++--
> ----
> >  libavcodec/avcodec.h        |   5 +-
> >  libavcodec/codec_internal.h |  12 ---
> >  libavcodec/dvbsubenc.c      |  96 ++++++++++--------
> >  libavcodec/dvdsubenc.c      | 103 ++++++++++++--------
> >  libavcodec/encode.c         |  61 +++++++++++-
> >  libavcodec/movtextenc.c     | 114 ++++++++++++++++------
> >  libavcodec/srtenc.c         | 108 ++++++++++++++-------
> >  libavcodec/tests/avcodec.c  |   5 +-
> >  libavcodec/ttmlenc.c        | 101 ++++++++++++++-----
> >  libavcodec/utils.c          |   1 -
> >  libavcodec/webvttenc.c      |  86 +++++++++++-----
> >  libavcodec/xsubenc.c        |  88 ++++++++++-------
> >  13 files changed, 689 insertions(+), 280 deletions(-)
> 
> Causes this testcase to fail:
> ./ffmpeg -i 'bgc.sub.dub.ogm'  -vframes 3 -bitexact -y nosubs.webm
> 
> https://samples.ffmpeg.org/ogg/
> 
> I did not investgate why or if this a bug or expected. Just reporting
> a difference
> ive seen

Hi Michael,

thanks a lot for testing my patchset! 

I have run the command with and without my patchset and I can confirm
that the output is different.

Though, from analyzing the output files, it appears that the output
with my patchset applied seems "more correct" than the output that ffmpeg
is currently creating.

The details of the investigation can be found here:
https://github.com/softworkz/SubtitleFilteringDemos/issues/2


Thanks again,
softworkz