[FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Fri Sep 23 18:11:22 EEST 2022


Zhao Zhili:
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> Signed-off-by: Zhao Zhili <zhilizhao at tencent.com>
> ---
>  libavcodec/mjpegdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c
> index c594950500..d77c644d3b 100644
> --- a/libavcodec/mjpegdec.c
> +++ b/libavcodec/mjpegdec.c
> @@ -2866,7 +2866,7 @@ the_end:
>          }
>      }
>  
> -    if (e = av_dict_get(s->exif_metadata, "Orientation", e, AV_DICT_IGNORE_SUFFIX)) {
> +    if ((e = av_dict_get(s->exif_metadata, "Orientation", e, AV_DICT_IGNORE_SUFFIX))) {
>          char *value = e->value + strspn(e->value, " \n\t\r"), *endptr;
>          int orientation = strtol(value, &endptr, 0);
>  

Since when do we care about this type of warning? Line 7087 of configure
adds -Wno-parentheses in case the compiler supports it.

- Andreas


More information about the ffmpeg-devel mailing list