[FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file.

[Tomas Härdin]

> +    for ( comp = 0; comp < component_count; comp++ ) {
> +        avio_write(pb, &sc->j2k_info.j2k_comp_desc[3*comp] , 3);
> +    }

Looks like this could be simplified to just

  avio_write(pb, sc->j2k_info.j2k_comp_desc, 3*component_count);

> +    if (j2k_ncomponents != component_count) {
> +        av_log(s, AV_LOG_ERROR, "Incoherence about components image
> number.\n");
> +    }

I again feel this should be a hard error

> +    for (comp = 0; comp < j2k_ncomponents; comp++) {
> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents] =
> bytestream2_get_byteu(&g);   // Bitdepth for each component
> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+1] =
> bytestream2_get_byteu(&g); // Horizontal sampling for each component
> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+2] =
> bytestream2_get_byteu(&g); // Vertical sampling for each component
> +    }

Could be simplified to a single avio_read()

/Tomas