[FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file (V2).

[Cédric Le Barz]

Le 19/12/2023 à 14:36, Tomas Härdin a écrit :
>> +    for ( comp = 0; comp < component_count; comp++ ) {
>> +        avio_write(pb, &sc->j2k_info.j2k_comp_desc[3*comp] , 3);
>> +    }
> Looks like this could be simplified to just
>
>    avio_write(pb, sc->j2k_info.j2k_comp_desc, 3*component_count);
>
>> +    if (j2k_ncomponents != component_count) {
>> +        av_log(s, AV_LOG_ERROR, "Incoherence about components image
>> number.\n");
>> +    }
> I again feel this should be a hard error
>
>> +    for (comp = 0; comp < j2k_ncomponents; comp++) {
>> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents] =
>> bytestream2_get_byteu(&g);   // Bitdepth for each component
>> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+1] =
>> bytestream2_get_byteu(&g); // Horizontal sampling for each component
>> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+2] =
>> bytestream2_get_byteu(&g); // Vertical sampling for each component
>> +    }
> Could be simplified to a single avio_read()
>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Here is the new version of the patch taken into account your remarks.

Regards,

Cédric Le Barz
-------------- next part --------------
An embedded message was scrubbed...
From: Cedric Le Barz <clebarz at ektacom.com>
Subject: [PATCH] Add jpeg2000 subdescriptor (V2).
Date: Fri, 8 Dec 2023 16:24:42 +0100
Size: 14569
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231220/3d68c344/attachment.eml>