[FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Jul 28 13:40:37 EEST 2023


> On 28 Jul 2023, at 03:37, L. E. Segovia <amy at amyspark.me> wrote:
>
> Updated for 6.0, any constructive feedback will be appreciated.

Using #if means the code will not even be compile tested if the
feature is disabled, this makes maintenance especially of rare
features much harder (nevermind code readability).
Also I believe we do not support compiling without optimizations
even on primary platforms like Linux/gcc, so I'd find it very unlikely
we'd want that for MSVC.
At least there would have to be a very good argument why this is so
important to have that we'd accept the drawbacks.

Best regards,
Reimar


More information about the ffmpeg-devel mailing list