[FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

[Reimar Döffinger]

> On 28 Jul 2023, at 12:40, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> 
> 
>> On 28 Jul 2023, at 03:37, L. E. Segovia <amy at amyspark.me> wrote:
>> 
>> Updated for 6.0, any constructive feedback will be appreciated.
> 
> Using #if means the code will not even be compile tested if the
> feature is disabled, this makes maintenance especially of rare
> features much harder (nevermind code readability).
> Also I believe we do not support compiling without optimizations
> even on primary platforms like Linux/gcc, so I'd find it very unlikely
> we'd want that for MSVC.
> At least there would have to be a very good argument why this is so
> important to have that we'd accept the drawbacks.

Since you asked for constructive feedback:
I assume the issue is missing symbols during linking?
If you really want this, why not create a file that provides dummy
symbols for all that are missing, concentrating the #if mess in
a single place and avoiding affecting any of the regular code, and thus
having no impact at all when compiling with optimizations.
Yes, it's likely to be a good bit of maintenance effort for those who
want to use it, but at least anyone not caring about this feature can
ignore it, so at least I would not have a reason to be against it.

Best regards,
Reimar