[FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

[Michael Niedermayer]

On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2023-10-15 02:13:23)
> > Fixes: Assertion failure
> > Fixes: 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> 
> The commit message is useless.

This comment is also not that usefull
What would you like to see in the commit message ?

The 2 checks are not redundant. Should the message detail how
the assertion failure occured ?

Would you prefer if the 2nd condition produces an error instead of return 0 ?

Is there something else ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231019/7818c40b/attachment.sig>