[FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant

[Anton Khirnov]

Quoting Michael Niedermayer (2023-10-19 18:33:13)
> On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2023-10-15 02:13:23)
> > > Fixes: Assertion failure
> > > Fixes: 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784
> > > 
> > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > ---
> > 
> > The commit message is useless.
> 
> This comment is also not that usefull
> What would you like to see in the commit message ?
> 
> The 2 checks are not redundant. Should the message detail how
> the assertion failure occured ?

At least two people previously thought that the condition is redundant,
so it seems clear to me that an explanation is in order.

I actually find it quite baffling that this is not obvious to you. Do
you really think that "Fixes: Assertion failure" is sufficient
explanation for anyone reading this patch?

> Would you prefer if the 2nd condition produces an error instead of return 0 ?

Maybe. Depending on the conditions under which this happens.

-- 
Anton Khirnov