[FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function

[Andreas Rheinhardt]

Stefano Sabatini:
> +static void print_frame_side_data(WriterContext *w,
> +                                  AVFrame *frame,
> +                                  AVStream *stream)

I am pretty sure both frame and stream can be constified.

> +{
> +    int i;

We support C99 variable declarations in for loops.

> +
> +    writer_print_section_header(w, SECTION_ID_FRAME_SIDE_DATA_LIST);
> +
> +    for (i = 0; i < frame->nb_side_data; i++) {
> +        AVFrameSideData *sd = frame->side_data[i];

This can probably be const, too.

> +        const char *name;