[FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function

[Stefano Sabatini]

On date Saturday 2023-09-02 10:33:12 +0200, Andreas Rheinhardt wrote:
> Stefano Sabatini:
> > +static void print_frame_side_data(WriterContext *w,
> > +                                  AVFrame *frame,
> > +                                  AVStream *stream)
> 
> I am pretty sure both frame and stream can be constified.
> 
> > +{
> > +    int i;
> 
> We support C99 variable declarations in for loops.
> 
> > +
> > +    writer_print_section_header(w, SECTION_ID_FRAME_SIDE_DATA_LIST);
> > +
> > +    for (i = 0; i < frame->nb_side_data; i++) {
> > +        AVFrameSideData *sd = frame->side_data[i];
> 
> This can probably be const, too.
> 
> > +        const char *name;

Updated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ffprobe-factorize-side-data-printing-to-dedicated-fu.patch
Type: text/x-diff
Size: 10236 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230902/394574c8/attachment.patch>