[FFmpeg-devel] [PATCH 1/2] fftools/ffplay: add missing YUV metadata to buffersrc

[Niklas Haas]

On Wed, 10 Jan 2024 10:05:46 +0100 Niklas Haas <ffmpeg at haasn.xyz> wrote:
> From: Niklas Haas <git at haasn.dev>
> 
> Fixes error spam from the `ffplay` tool since commit 2d555dc82d, caused
> by an oversight on my part - I didn't notice during development that
> `ffplay` goes through its own filtering code path separate from
> fftools/ffmpeg_filter.c
> ---
>  fftools/ffplay.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 17861e60be..0771326d76 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -1881,10 +1881,12 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c
>      graph->scale_sws_opts = av_strdup(sws_flags_str);
>  
>      snprintf(buffersrc_args, sizeof(buffersrc_args),
> -             "video_size=%dx%d:pix_fmt=%d:time_base=%d/%d:pixel_aspect=%d/%d",
> +             "video_size=%dx%d:pix_fmt=%d:time_base=%d/%d:pixel_aspect=%d/%d:"
> +             "colorspace=%d:range=%d",
>               frame->width, frame->height, frame->format,
>               is->video_st->time_base.num, is->video_st->time_base.den,
> -             codecpar->sample_aspect_ratio.num, FFMAX(codecpar->sample_aspect_ratio.den, 1));
> +             codecpar->sample_aspect_ratio.num, FFMAX(codecpar->sample_aspect_ratio.den, 1),
> +             frame->colorspace, frame->color_range);
>      if (fr.num && fr.den)
>          av_strlcatf(buffersrc_args, sizeof(buffersrc_args), ":frame_rate=%d/%d", fr.num, fr.den);
>  
> -- 
> 2.43.0
> 

Will merge tomorrow if there is no further objection, especially as it
now affects https://trac.ffmpeg.org/ticket/10839