[FFmpeg-devel] [PATCH 1/2] fftools/ffplay: add missing YUV metadata to buffersrc

Niklas Haas ffmpeg at haasn.xyz
Thu Feb 1 15:10:31 EET 2024


On Fri, 26 Jan 2024 18:17:30 +0800 Zhao Zhili <quinkblack at foxmail.com> wrote:
> 
> 
> > On Jan 26, 2024, at 17:36, Anton Khirnov <anton at khirnov.net> wrote:
> > 
> > Quoting Niklas Haas (2024-01-10 10:05:46)
> >> From: Niklas Haas <git at haasn.dev>
> >> 
> >> Fixes error spam from the `ffplay` tool since commit 2d555dc82d, caused
> >> by an oversight on my part - I didn't notice during development that
> >> `ffplay` goes through its own filtering code path separate from
> >> fftools/ffmpeg_filter.c
> > 
> > Wouldn't the same issue affect any other caller?
> 
> Firstly, can avfilter support color range/space change from unspecified to a specified value
> on the first frame? I think it should silent the log most of the cases.
> 
> Secondly, log once for non-serious case.

To clarify, commit 94422871fce3b90bebc95f5cae939fbbc4e33224 makes this
message drop from WARNING to DEBUG verbosity for subsequent print-outs.

So the error spam is no longer a major consideration, however it remains
that ffplay needs to set the correct metadata for YUV colorspace
negotiation to work inside the ffplay filter graph. (See the issue
I linked in my other mail)


More information about the ffmpeg-devel mailing list