[FFmpeg-devel] [PATCH] avformat/smoothstreamingenc: check return value of avcodec_parameters_copy()

[epirat07 at gmail.com]

On 12 Oct 2024, at 19:18, Marth64 wrote:

> Written in the dominant style of the surrounding code block.
>
> Signed-off-by: Marth64 <marth64 at proxyid.net>
> ---
>  libavformat/smoothstreamingenc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c
> index 9547419d31..adf3008003 100644
> --- a/libavformat/smoothstreamingenc.c
> +++ b/libavformat/smoothstreamingenc.c
> @@ -331,7 +331,9 @@ static int ism_write_header(AVFormatContext *s)
>          if (!(st = avformat_new_stream(ctx, NULL))) {
>              return AVERROR(ENOMEM);
>          }
> -        avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar);
> +        if ((ret = avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar)) < 0) {
> +            return ret;

Won’t this leak the stream created above as avformat_free_context is not called?

> +        }
>          st->sample_aspect_ratio = s->streams[i]->sample_aspect_ratio;
>          st->time_base = s->streams[i]->time_base;
>
> -- 
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".