[FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

[Nicolas George]

Stefano Sabatini (HE12025-04-21):
> > +    if (!pwctx || !avio_ctx)
> > +        return AVERROR(EINVAL);
> > +
> maybe warning in this case as well

Checking that an argument that must not be null is not null is the
responsibility of the caller: crashing here is the right thing to do,
same as fprintf(NULL, "fmt").

Therefore, an assertion is the best choice.

Regards,

-- 
  Nicolas George