[FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements
softworkz .
softworkz at hotmail.com
Mon Apr 21 20:40:18 EEST 2025
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Nicolas George
> Sent: Montag, 21. April 2025 19:21
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat:
> Quality improvements
>
> Stefano Sabatini (HE12025-04-21):
> > > + if (!pwctx || !avio_ctx)
> > > + return AVERROR(EINVAL);
> > > +
> > maybe warning in this case as well
>
> Checking that an argument that must not be null is not null is the
> responsibility of the caller: crashing here is the right thing to do,
> same as fprintf(NULL, "fmt").
>
> Therefore, an assertion is the best choice.
>
> Regards,
>
> --
> Nicolas George
> _______________________________________________
Okay, I'll do that.
Thank you.
sw
More information about the ffmpeg-devel
mailing list