[FFmpeg-devel] Fwd: [PATCH v2] avcodec/h264: fixed qp table attach for h264

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Mon Jun 16 12:32:15 EEST 2025


Timothee:
> Hello,
> 
> Thank you for the feedback on my first patch. The corruption was likely
> caused by my email client's text formatting.
> 
> The patch is attach to prevent any formatting error.
> 
> I have check the patch file applies cleanly using `git am` and verified
> that all FATE tests still pass.
> 
> Please let me know if this version is correct. Any advice is welcome.
> 
> Thanks,
> Timothée
> 

1. Commits should be small atomic units; changes to different libraries
in the same commit are almost always not of this type.
2. Both ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() already
set qscale_table on their own (on success), so that all the changes to
h264_slice.c seem completely redundant.

- Andreas



More information about the ffmpeg-devel mailing list