[FFmpeg-devel] Fwd: [PATCH v2] avcodec/h264: fixed qp table attach for h264

[Timothee]

Hello,

Thank you for the feedback.

You are right and the changes to h264_slice.c seem redundant. I will 
remove that. and run the tests again.

Should I make two differents commits to change qp_table.c and qp_table.h ?

Thanks,

Timothée

On 16/06/2025 à 11:32, Andreas Rheinhardt wrote :

> Timothee:
>> Hello,
>>
>> Thank you for the feedback on my first patch. The corruption was likely
>> caused by my email client's text formatting.
>>
>> The patch is attach to prevent any formatting error.
>>
>> I have check the patch file applies cleanly using `git am` and verified
>> that all FATE tests still pass.
>>
>> Please let me know if this version is correct. Any advice is welcome.
>>
>> Thanks,
>> Timothée
>>
> 1. Commits should be small atomic units; changes to different libraries
> in the same commit are almost always not of this type.
> 2. Both ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() already
> set qscale_table on their own (on success), so that all the changes to
> h264_slice.c seem completely redundant.
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".