[FFmpeg-devel] [FFmpeg-cvslog] hwcontext_vulkan: use host image copy

[Martin Storsjö]

On Wed, 11 Jun 2025, Lynne wrote:

> ffmpeg | branch: master | Lynne <dev at lynne.ee> | Mon May 12 18:42:09 2025 +0200| [a9b2c10eee9cf28ecbce2f1972564f4aa826a855] | committer: Lynne
>
> hwcontext_vulkan: use host image copy
>
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a9b2c10eee9cf28ecbce2f1972564f4aa826a855
> ---
>
> libavutil/hwcontext_vulkan.c | 123 ++++++++++++++++++++++++++++++++++++++++++-
> libavutil/vulkan.c           |  35 ++++++++++++
> libavutil/vulkan.h           |   2 +
> libavutil/vulkan_functions.h |   6 +++
> libavutil/vulkan_loader.h    |   1 +
> 5 files changed, 165 insertions(+), 2 deletions(-)

This change breaks compilation on Ubuntu 24.04:

CC      libavcodec/vulkan.o
In file included from src/libavutil/vulkan.c:24,
                  from src/libavcodec/vulkan.c:19:
src/libavutil/vulkan.c: In function ‘ff_vk_load_props’:
src/libavutil/vulkan.c:166:22: error: 
‘VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_IMAGE_COPY_PROPERTIES’ undeclared 
(first use in this function); did you mean 
‘VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_IMAGE_COPY_PROPERTIES_EXT’?
   166 | 
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_HOST_IMAGE_COPY_PROPERTIES);
       | 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


src/libavutil/hwcontext_vulkan.c: In function ‘vulkan_frames_init’:
src/libavutil/hwcontext_vulkan.c:2838:47: error: 
‘VK_IMAGE_USAGE_HOST_TRANSFER_BIT’ undeclared (first use in this 
function); did you mean ‘VK_IMAGE_USAGE_HOST_TRANSFER_BIT_EXT’?
  2838 |             hwctx->usage |= supported_usage & 
VK_IMAGE_USAGE_HOST_TRANSFER_BIT;
       | 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       | 
VK_IMAGE_USAGE_HOST_TRANSFER_BIT_EXT
src/libavutil/hwcontext_vulkan.c:2838:47: note: each undeclared identifier 
is reported only once for each function it appears in
src/libavutil/hwcontext_vulkan.c: In function ‘vulkan_transfer_host’:
src/libavutil/hwcontext_vulkan.c:4173:5: error: unknown type name 
‘VkHostImageLayoutTransitionInfo’; did you mean 
‘VkHostImageLayoutTransitionInfoEXT’?
  4173 |     VkHostImageLayoutTransitionInfo layout_ch_info[];
       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       |     VkHostImageLayoutTransitionInfoEXT
src/libavutil/hwcontext_vulkan.c:4173:37: error: array size missing in 
‘layout_ch_info’
  4173 |     VkHostImageLayoutTransitionInfo layout_ch_info[];
       |                                     ^~~~~~~~~~~~~~

(and many more errors)

// Martin