[FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

Tristan Matthews httamt at protonmail.com
Thu Jun 26 00:39:16 EEST 2025


On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt <andreas.rheinhardt at outlook.com> wrote:

> Tristan Matthews via ffmpeg-devel:
> 
> > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt andreas.rheinhardt at outlook.com wrote:
> > 
> > > Patch attached.
> > 
> > LGTM, and sorry about that, for future reference did you do anything in particular (instrumentation wise) to catch the stack overflow? I tried make fate on a few different machines and didn't hit that.
> > 
> > Best,
> > Tristan
> 
> 
> I used (Clang) ASAN. Presumably Zhao Zhili (who first reported the stack
> buffer overflow) did so, too.
> 
> - Andreas
> 

It'd be good to merge either this or Zhao Zhili's patch to get checkasm back to being ASAN clean.

Best,
Tristan


More information about the ffmpeg-devel mailing list