[Mplayer-cvslog] UNAPPLIED PATCHES?

[Arpi]

Hi,

> Can I apply this patch?
no

>  The FFmpeg project provides libavcodec, a very portable MPEG4/DivX codec with
it's not only mpeg4/divx

> -excellent speed and quality.  It is the preferred codec of MPlayer for playing
> -mpeg4 and divx video.  You have to get libavcodec directly from the FFmpeg CVS
> -server. Use the following commands in a suitable directory outside the MPlayer
> -source directory:
> +excellent speed and quality. It is the preferred MPEG4/DivX codec of MPlayer
> +and used to be included in the MPlayer CVS tree.  This is no longer the case
> +and you have to get libavcodec directly from the FFmpeg CVS server.

why do you bring that most discussed 'used to be included in cvs' thingie
back???

> +
> +If you are using an official (pre)release, skip this step, since official
> +releases include libavcodec. CVS sources and CVS snapshots do not include
> +libavcodec. To verify if you do have libavcodec or not, check if the libavcodec
> +subdirectory in the MPlayer source tree is empty or not.
> +
> +To get the FFmpeg sources, use the following commands in a suitable directory
> +outside the MPlayer source directory:
>  
>  cvs -d:pserver:anonymous at cvs.ffmpeg.sourceforge.net:/cvsroot/ffmpeg login
> -cvs -z9 -d:pserver:anonymous at cvs.ffmpeg.sourceforge.net:/cvsroot/ffmpeg co ffmpeg/libavcodec
> +cvs -z3 -d:pserver:anonymous at cvs.ffmpeg.sourceforge.net:/cvsroot/ffmpeg co ffmpeg/libavcodec

-z9 is better compression, don't change this

>  
> -While MPlayer and libavcodec has built-in support for the most common audio
> -and video formats, some others are playable only with the Win32 DLLs
> -or the XAnim binary plugins. Few examples: WMV video, Divx/WMA audio, Indeo.
> -This step is not mandatory, but recommended for getting MPlayer to play more
> -different file types!
> -
> -Grab the win32 codecs package from the download page
> -
> -  http://www.mplayerhq.hu/homepage/dload.html
> +MPlayer and libavcodec have builtin support for the most common audio and video
> +formats, but some others are playable only with the Win32 DLLs or the XAnim
> +binary plugins. Examples include WMV video, DivX with WMA audio (not normal

this wma thing was also discussed earlier

please don't bring old things back we voted out already

> -To enable OSD (onscreen status display) and ASCII/TEXT subtitles you need some
> -fonts. Get them from our homepage:
> +Unpack the archive and choose one of the available font sizes. Then copy the
> +font files of the corresponding size into /usr/local/share/mplayer/font/ or
> +~/.mplayer/font/ (or whatever you set with './configure --datadir=DIR').
>  
> -http://www.mplayerhq.hu/homepage/dload.html
> -
> -Unpack the archive and choose one of the available font sizes.  Then copy the
> -font files of the corresponding size into /usr/local/share/mplayer/font/
> -(or whatever you set with './configure --datadir=DIR').
>  
why did you removed explanation?

> -Please remember that the GUI is still in the alpha development stage and not
> -completely finished yet. Features like playlist, preferences and equalizer
> -do not work at all. Expect them for the 1.0 release
> -Basic stuff like file selection and seeking works, though.

same here

> +  mplayer -gui <moviefile>
why +?

>    gmplayer <moviefile>
> -  (just 'gmplayer' is enough to use the GUI fileselector)
why -?

your patch has nice parts but mostly bad changes
i'll manually merge good things from it, don't commit.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu