[Mplayer-cvslog] CVS: main/DOCS/tech patches.txt,1.9,1.10

[Michael Niedermayer]

Hi

On Monday 20 October 2003 15:47, Diego Biurrun CVS wrote:
> Update of /cvsroot/mplayer/main/DOCS/tech
> In directory mail:/var/tmp.root/cvs-serv9241/DOCS/tech
>
> Modified Files:
> 	patches.txt
> Log Message:
> Explain why sending complete files is a bad idea.
[...]
> +0. Do not send complete files. These need to be diffed by hand to see the
> +   changes, which makes reviews harder and less likely to occur. Besides
> as 
> +   soon as one of the files changes, your version becomes obsolete. 
not exactly, the following needs to be done 
1. use cvsweb & cvs -z3 update -d <date> to figure out to which time the patch 
fits best (diff -u | wc or so could be used)
2. generate a diff against that cvs from that time
3. clean the diff up by hand, as it will very likely contain unrelated 
changes, which the author forgot, as he never saw the diff
4. apply/reject/comment it

[...]

-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en