[Mplayer-cvslog] CVS: main/DOCS/tech patches.txt,1.9,1.10

[Diego Biurrun]

On Mon, Oct 20, 2003 at 04:11:53PM +0200, Michael Niedermayer wrote:
> On Monday 20 October 2003 15:47, Diego Biurrun CVS wrote:
> > Update of /cvsroot/mplayer/main/DOCS/tech
> > In directory mail:/var/tmp.root/cvs-serv9241/DOCS/tech
> >
> > Modified Files:
> > 	patches.txt
> > Log Message:
> > Explain why sending complete files is a bad idea.
> [...]
> > +0. Do not send complete files. These need to be diffed by hand to see the
> > +   changes, which makes reviews harder and less likely to occur. Besides
> > as 
> > +   soon as one of the files changes, your version becomes obsolete. 
> not exactly, the following needs to be done 
> 1. use cvsweb & cvs -z3 update -d <date> to figure out to which time the patch 
> fits best (diff -u | wc or so could be used)
> 2. generate a diff against that cvs from that time
> 3. clean the diff up by hand, as it will very likely contain unrelated 
> changes, which the author forgot, as he never saw the diff
> 4. apply/reject/comment it

I know it is possible recreate a proper patch from complete files, but as
you pointed out, it is quite a lot of work that should definitely not be on
our side, but be taken care of by the sender.

I'll rephrase the section later to make this clearer.

Diego