[Mplayer-cvslog] CVS: main configure,1.915,1.916

[Attila Kinali]

On Sun, Sep 26, 2004 at 04:49:36PM +0200, Sascha Sommer CVS wrote:
> +short asci_name[] = { (('M'<<8)|'P'),(('l'<<8)|'a'),(('y'<<8)|'e'),(('r'<<8)|0)};

This test will fail if short is not 16bit on the target architecture.
What about using an int and "MPla" ? It's quite safe to assume, that
an int is at least 32byte (16bit systems wont be able to run MPlayer
anyways). Note that assuming that int is always 32bit is also not safe,
ie using two ints with "MPla" + "yer " would fail on a 64bit target
architecture.
If int is not long enough, ie "MPla" can apear in compiled code too,
we should use a long long, after it has been tested to be 64bit.

BTW: there are a lot of checks that depend on the architecture you
run them on, did you check them whether they are safe for cross
compiling ?

			Attila Kinali