[Mplayer-cvslog] CVS: main configure,1.915,1.916

[D Richard Felker III]

On Mon, Sep 27, 2004 at 02:49:23PM +0900, Attila Kinali wrote:
> On Sun, Sep 26, 2004 at 04:49:36PM +0200, Sascha Sommer CVS wrote:
> > +short asci_name[] = { (('M'<<8)|'P'),(('l'<<8)|'a'),(('y'<<8)|'e'),(('r'<<8)|0)};
> 
> This test will fail if short is not 16bit on the target architecture.

If short is not 16bit, there's absolutely no hope of running mplayer.
How do you expect audio to work?? :)

> What about using an int and "MPla" ? It's quite safe to assume, that
> an int is at least 32byte (16bit systems wont be able to run MPlayer
> anyways). Note that assuming that int is always 32bit is also not safe,

Yes it is. If int is not 32bit, then you're either missing a 16bit
type or missing a 32bit type (short can't be both 16bit and 32bit).
Either way you're hopelessly in trouble...

> ie using two ints with "MPla" + "yer " would fail on a 64bit target
> architecture.

False. int is 32bit even on 64bit targets. And probably always will be
due to the above oversights in the design of C...

Rich