[MPlayer-cvslog] CVS: main Makefile,1.318,1.319

[Rich Felker]

On Wed, Apr 20, 2005 at 02:01:42PM +0200, Reimar Döffinger CVS wrote:
> CVS change done by Reimar Döffinger CVS
> 
> Update of /cvsroot/mplayer/main
> In directory mail:/var2/tmp/cvs-serv136
> 
> Modified Files:
> 	Makefile 
> Log Message:
> Link with -z noexecstack, fixes bug #258. Please test on all platforms!
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/mplayer/main/Makefile,v
> retrieving revision 1.318
> retrieving revision 1.319
> diff -u -r1.318 -r1.319
> --- Makefile	16 Apr 2005 20:18:12 -0000	1.318
> +++ Makefile	20 Apr 2005 12:01:39 -0000	1.319
> @@ -244,7 +244,7 @@
>      ifeq ($(TARGET_WIN32),yes)
>  	windres -o osdep/mplayer-rc.o osdep/mplayer.rc
>      endif
> -	$(CC) $(CFLAGS) -o $(PRG) $(OBJS_MPLAYER) libvo/libvo.a libao2/libao2.a $(MENU_LIBS) $(VIDIX_LIBS) $(GUI_LIBS) $(COMMON_LIBS) $(GTK_LIBS) $(VO_LIBS) $(AO_LIBS) $(EXTRA_LIB) $(LIRC_LIB) $(LIRCC_LIB) $(STATIC_LIB) $(ARCH_LIB) $(I18NLIBS) $(MATH_LIB)
> +	$(CC) $(CFLAGS) -Wl,-z,noexecstack -o $(PRG) $(OBJS_MPLAYER) libvo/libvo.a libao2/libao2.a $(MENU_LIBS) $(VIDIX_LIBS) $(GUI_LIBS) $(COMMON_LIBS) $(GTK_LIBS) $(VO_LIBS) $(AO_LIBS) $(EXTRA_LIB) $(LIRC_LIB) $(LIRCC_LIB) $(STATIC_LIB) $(ARCH_LIB) $(I18NLIBS) $(MATH_LIB)

Are you sure this works with linkers that don't recognize this new
nonsense? I expect it does not! You're in for a huge truckload of cola
if it's broken now... :)

Rich