[MPlayer-cvslog] CVS: main/libvo vo_xvmc.c,1.24,1.25

[The Wanderer]

On 12/20/2005 02:04 PM, Ivan Kalvachev CVS wrote:

>     rez = XvMCCreateContext(mDisplay, xv_port,mode_id,width,height,XVMC_DIRECT,&ctx);
> -   if( rez != Success ) return -1;
> +   if( rez != Success ){
> +      printf("vo_xvmc: XvMCCreateContext failed with error %d\n",rez);

Please use mp_msg instead of printf. I know that there are 'way too many
printfs in that file already, but we don't need to add more of them to
be fixed later.

It's probably also a good idea to put the message itself in the
translatables file, unless it is intended to only appear at -v or
higher.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.