[MPlayer-cvslog] CVS: main/libvo vo_xvmc.c,1.24,1.25

Ivan Kalvachev ikalvachev at gmail.com
Tue Dec 20 23:26:00 CET 2005


2005/12/20, The Wanderer <inverseparadox at comcast.net>:
> On 12/20/2005 02:04 PM, Ivan Kalvachev CVS wrote:
>
> >     rez = XvMCCreateContext(mDisplay, xv_port,mode_id,width,height,XVMC_DIRECT,&ctx);
> > -   if( rez != Success ) return -1;
> > +   if( rez != Success ){
> > +      printf("vo_xvmc: XvMCCreateContext failed with error %d\n",rez);
>
> Please use mp_msg instead of printf. I know that there are 'way too many
> printfs in that file already, but we don't need to add more of them to
> be fixed later.
>
> It's probably also a good idea to put the message itself in the
> translatables file, unless it is intended to only appear at -v or
> higher.

I'm planning to make an big conversion to mp_msg soon, until then it
stays consistent ;).

I would be very happy if I don't have to deal with error in languages
i cannot even display....
:P




More information about the MPlayer-cvslog mailing list