[MPlayer-cvslog] CVS: main/libvo vo_sdl.c,1.118,1.119

Reimar =?UTF8?Q?D=F6ffinger?= Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Mar 1 12:24:06 CET 2005

On Tue, Mar 01, 2005 at 04:51:50AM +0100, Ivo van Poorten CVS wrote:
> +    if(sdl_driver) setenv("SDL_VIDEODRIVER", sdl_driver, 1);
> +    free(sdl_driver);

Most MPlayer code checks if a pointer is null before freeing - but
actually I think it can never be null, so the check above actually makes
no sense - unfortunatly this also means that the code now forces the X11
SDL driver by default. Am I correct here? And is this really a good

Reimar D?ffinger

More information about the MPlayer-cvslog mailing list