[MPlayer-cvslog] CVS: main/libvo vo_sdl.c,1.118,1.119

[Ivo]

On Tuesday 01 March 2005 12:24, Reimar Dffinger wrote:
> On Tue, Mar 01, 2005 at 04:51:50AM +0100, Ivo van Poorten CVS wrote:
> > +    if(sdl_driver) setenv("SDL_VIDEODRIVER", sdl_driver, 1);
> > +    free(sdl_driver);
>
> Most MPlayer code checks if a pointer is null before freeing - but
> actually I think it can never be null, so the check above actually makes
> no sense - unfortunatly this also means that the code now forces the X11
> SDL driver by default. Am I correct here? And is this really a good
> idea?

I assumed X11 was the default already, but I suppose that's not the case? If 
you think this should be changed and it shouldn't set SDL_VIDEODRIVER if 
the driver= option isn't passed to vo_sdl, I can do so and also fix the 
if-statement and freeing of sdl_driver.

--Ivo