[MPlayer-cvslog] CVS: main/libmpcodecs vf_scale.c,1.57,1.58

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Mar 7 12:06:09 CET 2005

On Sun, Mar 06, 2005 at 10:44:00PM +0100, Nico Sabbi wrote:
> Oded Shimon wrote:
> >On Sunday 06 March 2005 23:15, Nico Sabbi CVS wrote:
> >>+      vf->priv->w = -(-vf->priv->w & ~8);
> >>   
> >Why didn't you change this to
> >vf->priv->w += 8;
> >after all?
> >As far as I can tell, it's completely identical, and much more readable...
> >Also personally in the 'if', I would've done '<= -8' instead of the mess 
> >that is over there.
> >
> >Should I submit a cosmetics patch? :)
> no, I'll let Reimar decide and fix it if he wants, I'm sure he will, 
> won't you Reimar?  :)

Well, I didn't think about it a lot an I'm not sure the other variant is
exactly the same... So I'll leave it as it is at least for now, maybe
I'll do something about it when I'm back from holidays (on April 10, so
expect to hear nothing from me for a long time *g*)

Reimar Döffinger

More information about the MPlayer-cvslog mailing list