[MPlayer-cvslog] CVS: main/libmpcodecs vf_scale.c,1.57,1.58

[Oded Shimon]

On Monday 07 March 2005 07:52, D Richard Felker III wrote:
> > Also personally in the 'if', I would've done '<= -8' instead of the mess
> > that is over there.
> >
> > Should I submit a cosmetics patch? :)
>
> No, you should test your proposed nonsense first and see that it
> doesn't work before proposing it. :)

for (a = -8; a > -16; a--)
        printf("%d %d\n", -(-a & ~8), a + 8);

0 0
-1 -1
-2 -2
-3 -3
-4 -4
-5 -5
-6 -6
-7 -7

I think the part you missed was the 'if' RIGHT above this code - this code is 
only reached if the numbers are already BELOW or equal to -8 !

Reimar refused to make a patch, and imho the last thing MPlayer needs is more 
obfuscated code... I'm gonna make a patch, I still think I'm right about the 
code being identical, if not, could you enlighten me?...

- ods15