[MPlayer-cvslog] CVS: main m_config.c, 1.15, 1.16 m_config.h, 1.7, 1.8 m_option.c, 1.49, 1.50 m_option.h, 1.14, 1.15 m_property.c, 1.3, 1.4 m_property.h, 1.3, 1.4 m_struct.c, 1.4, 1.5 m_struct.h, 1.3, 1.4

[Alban Bedel]

On Wed, 26 Apr 2006 02:25:15 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Tue, Apr 25, 2006 at 09:14:57PM +0200, Alban Bedel wrote:
> > On Tue, 25 Apr 2006 19:03:30 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > > -// Presets are mean to be used with options struct
> > 
> > That will be hard to fix now :) Otherwise i fixed most of the rest.
> >  
> > > Albeu, come on, you haven't used *a single* third person singular s in
> > > that much text.  You can do better than that!
> > 
> > Sure i can, but generaly only for a short period of time. My brain simply
> > have difficulties including rules that make no sense (as it just fuck the
> > branch prediction ;). And most of the rules in human language are just that,
> > old useless crap that is just there bcs it was already there before :(
> 
> Uh, oh, what do you have to say about French then?  It's much more
> complex and illogical than English...

Yeah French is much worse. I don't write French very often, i suppose my
english is better nowadays (a shame isn't it).

> Besides, that does not excuse leaving out the plural s ;p

Well that's just that, an excuse ;)

> Don't get me wrong, I very much appreciate that you document stuff and
> your English has improved markedly over the years.  But you know
> yourself that it can still get better.  And if it does, we both benefit.

Sure. Althought in the case of strange rules i don't have much hopes.
I learned all this several times, it never stayed for long.

> > > Before I sound too negative: It's excellent that you sat down and
> > > documented all this code, three cheers :-)
> > 
> > Thanks :) Now it's my turn to complain ;) Next time could you keep the diff
> > headers ? That would make things easier to read.
> 
> Yes, sorry, I figured that out myself after having gone through most of
> the review, but it was too late :(  I'll keep them next time.
> 
> > If you could (at least sometimes) just commit the fix yourself that would
> > also be nice. For you it is probably just trivial to do, where i often
> > need a bit of thinking to find and fix the mistakes you pointed out.
> 
> I do that in fact, most of the time even.  But I also try to teach
> everybody a bit and make them fix at least the recurring mistakes in the
> hope that they will avoid them in the future.  I think so far it's
> working just as it does for code reviews.  I was a bit terse with this
> review as it's very long and the same issues keep repeating.  I wanted
> to make a point for you to remember.  Whether this worked - I don't
> know..

I know this and have big respect for it. Playing the english teacher is
probably not much fun.

> Also, don't forget that the code devs outnumber the docs devs 10:1 and
> fixing everybody else's basic spelling/grammar mistakes is a lot of work
> and not a terribly sexy thing to do...

That's true, althought there doesn't seems to be much work going on with
the docs. I might be mistaking as i don't see the commits, but for one
thing i know that the OSD menu section still hadn't seen a single update.
It still state "the Preferences menu is currently UNIMPLEMENTED!" althought
i implemented it for quiet sometimes now (and mentioned that on irc
several times).

To tell the truth my impression is that the current doc team doesn't write
docs anymore. Instead pressure is put on the dev to have them writting poor
docs which is then eventually rewrote and/or heavily corrected by the doc
team. I miss the times where the doc ppl acctually wrote most of the docs
themself.

	Albeu

PS: No i'm not trying to argue that the devs should stop writing any docs.
    Just that the doc ppl should do a bit more effort, and sometimes
    instead of just flaming for poor/missing docs also get the dammn
    job done.