[MPlayer-cvslog] CVS: main/vidix/drivers nvidia_vid.c,1.33,1.34

[Oded Shimon]

On Thu, Apr 27, 2006 at 07:20:04PM +0200, Diego Biurrun CVS wrote:
> CVS change done by Diego Biurrun CVS
> 
> Update of /cvsroot/mplayer/main/vidix/drivers
> In directory mail:/var2/tmp/cvs-serv11140/vidix/drivers
> 
> Modified Files:
> 	nvidia_vid.c 
> Log Message:
> Remove unnecessary le2me_32 macros.
> 
> 
> Index: nvidia_vid.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/vidix/drivers/nvidia_vid.c,v
> retrieving revision 1.33
> retrieving revision 1.34
> diff -u -r1.33 -r1.34
> --- nvidia_vid.c	9 Feb 2006 18:17:04 -0000	1.33
> +++ nvidia_vid.c	27 Apr 2006 17:20:01 -0000	1.34
> @@ -217,9 +217,9 @@
>  #define VID_RD08(p,i)     ({ MEM_BARRIER(); ((uint8_t *)(p))[(i)]; })
>  
>  #undef	VID_WR32
> -#define VID_WR32(p,i,val) ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]=le2me_32(val); })
> +#define VID_WR32(p,i,val) ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]=val; })
>  #undef	VID_RD32
> -#define VID_RD32(p,i)     ({ MEM_BARRIER(); le2me_32(((uint32_t *)(p))[(i)/4]); })
> +#define VID_RD32(p,i)     ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]; })

1. why are we using this abonomination gcc extention?
2. I believe you that this le2me_32 was unnecessary, does that mean this 
code didn't work on be machines until now?

- ods15