[MPlayer-cvslog] CVS: main/vidix/drivers nvidia_vid.c,1.33,1.34

[Diego Biurrun]

On Thu, Apr 27, 2006 at 08:39:09PM +0300, Oded Shimon wrote:
> On Thu, Apr 27, 2006 at 07:20:04PM +0200, Diego Biurrun CVS wrote:
> > 
> > Modified Files:
> > 	nvidia_vid.c 
> > Log Message:
> > Remove unnecessary le2me_32 macros.
> > 
> > --- nvidia_vid.c	9 Feb 2006 18:17:04 -0000	1.33
> > +++ nvidia_vid.c	27 Apr 2006 17:20:01 -0000	1.34
> > @@ -217,9 +217,9 @@
> >  #define VID_RD08(p,i)     ({ MEM_BARRIER(); ((uint8_t *)(p))[(i)]; })
> >  
> >  #undef	VID_WR32
> > -#define VID_WR32(p,i,val) ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]=le2me_32(val); })
> > +#define VID_WR32(p,i,val) ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]=val; })
> >  #undef	VID_RD32
> > -#define VID_RD32(p,i)     ({ MEM_BARRIER(); le2me_32(((uint32_t *)(p))[(i)/4]); })
> > +#define VID_RD32(p,i)     ({ MEM_BARRIER(); ((uint32_t *)(p))[(i)/4]; })
> 
> 1. why are we using this abonomination gcc extention?

Ask Sascha, he is the author.

> 2. I believe you that this le2me_32 was unnecessary, does that mean this 
> code didn't work on be machines until now?

Yes.

Diego